fix: restore Herdr live steering and pane reads - #49
Open
ruby-dlee wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Restore firstmate live supervision for every Herdr-backed crewmate: fm-send.sh must deliver literal text, submit it, verify submission, and retry Enter without retyping when an autocomplete popup swallows the first Enter; fm-peek.sh must return real pane content. Fix the firstmate Herdr adapter defect rather than working around Herdr, preserve the explicit legacy certificate lab safety contract, eliminate the schema-probe broken-pipe path, add a regression that fails on the broken behavior, and record empirical evidence. The user requires verification against a real already-running Herdr pane without creating or driving a default-session lab. Ship through a PR and green CI, but do not merge. Main currently has a known unrelated Behavior test failure being fixed on another fresh branch; if this PR reports that identical inherited failure, identify it explicitly and do not chase it as part of this change.
What Changed
fm-send.shandfm-peek.shfor running native-agent Herdr servers while retaining certificate enforcement in the explicit legacy lifecycle lab.jqto eliminate pipefail-related broken pipes, and correct enforced-routing guidance for native agent startup.Risk Assessment
✅ Low: The change is narrowly scoped, restores native Herdr read/steer routing while preserving the opt-in legacy certificate contract, and replaces the broken-pipe-prone capability probe with full JSON parsing backed by focused regressions and documented live-pane evidence.
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"🔧 Fix: Stabilize Herdr send regression tests
1 error still open:
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"🔧 **Document** - 1 issue found → auto-fixed ✅
bin/fm-spawn.sh:2337- The enforced-routing error still claims Herdr requires a process-bound closed-shell certificate, contradicting the documented native-agent cutover. Resolving it requires editing an executable error string, which this documentation-only task forbids.🔧 Fix: Correct Herdr enforced-routing error guidance
✅ Re-checked - no issues remain.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.